Fixed brightness resetting on first gesture#3101
Fixed brightness resetting on first gesture#3101Ullas-Aithal wants to merge 1 commit intoTeamNewPipe:devfrom
Conversation
|
Are you sure that
Couldn't this go below 0? |
We do get negative value of -1 if the user has never used brightness gesture. But since we're not using any negative value for ProgressBar using setMin(), the default minimum is 0. So assigning a negative value will default to 0 in our case. I guess we can set the gesture value to be whatever the system brightness is if the user has never used the gesture? |
|
@Ullas-Aithal #3102 also adds debug information, so I think it is preferable. So you probably shouldn't work on this PR, sorry ;-) |
|
@Stypox that's totally fine. I'll probably take a look at another bug maybe. Thank you for maintaining this app! |
|
@Ullas-Aithal I merged #3102 in the end. Thank you for your contribution, anyway! :-) |
Fixes #3084
Brightness gesture now works the same ways as volume gesture. The brightness progress bar value is set to previously saved gesture value and increases/decreases value based on relative moment from this value. Previously saved brightness gesture value is calculated by current screen brightness.
Tested different brightness values and verified if the value persists in the next play.
app-debug.zip